[
https://issues.apache.org/jira/browse/TS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091382#comment-15091382
]
ASF GitHub Bot commented on TS-4113:
------------------------------------
GitHub user hnakamur opened a pull request:
https://github.com/apache/trafficserver/pull/411
Doc: [TS-4113] Add value 4 to proxy.config.http.cache.cache_responses…
Please refer to https://issues.apache.org/jira/browse/TS-4113
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hnakamur/trafficserver
add_value_4_for_proxy_config_http_cache_cache_responses_to_cookies
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/411.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #411
----
commit 8fc24ab19f9a26d6b672b41c7c400c6d5ccfba2b
Author: Hiroaki Nakamura <[email protected]>
Date: 2016-01-11T03:32:36Z
Doc: [TS-4113] Add value 4 to
proxy.config.http.cache.cache_responses_to_cookies
----
> Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies
> -----------------------------------------------------------------------
>
> Key: TS-4113
> URL: https://issues.apache.org/jira/browse/TS-4113
> Project: Traffic Server
> Issue Type: Bug
> Components: Docs, Documentation
> Reporter: Hiroaki Nakamura
> Assignee: Jon Sime
> Fix For: Docs
>
>
> Currently there are values 0 to 3 at
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
> 0 = do not cache any responses to cookies
> 1 = cache for any content-type
> 2 = cache only for image types
> 3 = cache for all but text content-types
> {quote}
> However there are 0 to 4 values in the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
> // # cache responses to cookies has 4 options
> // #
> // # 0 - do not cache any responses to cookies
> // # 1 - cache for any content-type (ignore cookies)
> // # 2 - cache only for image types
> // # 3 - cache for all but text content-types
> // # 4 - cache for all but text content-types except OS response
> without "Set-Cookie" or with "Cache-Control: public"
> {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies",
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should add the docs about the value 4
> 4 = cache for all but text content-types except OS response without
> "Set-Cookie" or with "Cache-Control: public
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
