[ 
https://issues.apache.org/jira/browse/TS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095372#comment-15095372
 ] 

ASF subversion and git services commented on TS-4113:
-----------------------------------------------------

Commit 48c23ec742f173e79793597cedea3ac970807cff in trafficserver's branch 
refs/heads/master from [~hnakamur]
[ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=48c23ec ]

TS-4113: add value 4 to proxy.config.http.cache.cache_responses_to_cookies

This closes #411.


> Docs: Add value 4 to proxy.config.http.cache.cache_responses_to_cookies
> -----------------------------------------------------------------------
>
>                 Key: TS-4113
>                 URL: https://issues.apache.org/jira/browse/TS-4113
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Docs, Documentation
>            Reporter: Hiroaki Nakamura
>            Assignee: Jon Sime
>             Fix For: 6.2.0, Docs
>
>
> Currently there are values 0 to 3 at 
> http://trafficserver.readthedocs.org/en/latest/admin-guide/files/records.config.en.html#proxy-config-http-cache-cache-responses-to-cookies
> {quote}
>     0 = do not cache any responses to cookies
>     1 = cache for any content-type
>     2 = cache only for image types
>     3 = cache for all but text content-types
> {quote}
> However there are 0 to 4 values in the source code
> https://github.com/apache/trafficserver/blob/d197d75601772139ea489dc5686fd041dc3c257a/mgmt/RecordsConfig.cc#L643-L650
> {quote}
>   //       # cache responses to cookies has 4 options
>   //       #
>   //       #  0 - do not cache any responses to cookies
>   //       #  1 - cache for any content-type (ignore cookies)
>   //       #  2 - cache only for image types
>   //       #  3 - cache for all but text content-types
>   //       #  4 - cache for all but text content-types except OS response 
> without "Set-Cookie" or with "Cache-Control: public"
>   {RECT_CONFIG, "proxy.config.http.cache.cache_responses_to_cookies", 
> RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_INT, "[0-4]", RECA_NULL}
> {quote}
> So we should add the docs about the value 4
>     4 = cache for all but text content-types except OS response without 
> "Set-Cookie" or with "Cache-Control: public



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to