[
https://issues.apache.org/jira/browse/TS-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133863#comment-15133863
]
ASF GitHub Bot commented on TS-4172:
------------------------------------
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-180258234
I agree with we should keep consistency. So, I'm going to keep current
names and debug tag in Http2ClientSession.
The problem is same name (DebugHttp2Ssn) and tag (http2_cs) are used in
both Http2ClientSession and Http2ConnectionState.
As you know, thoes two are different classes completely. Http2ClientSession
is low level class to handle VConnection to client and Http2ConnectionState is
high level class to handle HTTP/2 frames and streams.
When I'm debugging HTTP/2 component, I want to see debug logs from only
Http2ConnectionState to check what frame is received or sent in which stream in
many times.
> Cleanup debug logs of Http2ConnectionState
> ------------------------------------------
>
> Key: TS-4172
> URL: https://issues.apache.org/jira/browse/TS-4172
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Masaori Koshiba
> Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> 1. {{http2_cs}} debug tag is used in {{Http2ClientSession}} and
> {{Http2ConnectionState}} classes. This sometimes makes me confused when I
> debug HTTP/2 components.
> It is better to change debug tag of {{Http2ConnectionState}} to
> {{http2_conn}}.
> 2. Some debug logs has stream id. It is better that other debug logs in
> {{Http2ConnectionState}} has stream id too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
