[
https://issues.apache.org/jira/browse/TS-4172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15140313#comment-15140313
]
ASF GitHub Bot commented on TS-4172:
------------------------------------
Github user masaori335 commented on the pull request:
https://github.com/apache/trafficserver/pull/454#issuecomment-182200775
@bryancall It looks good. But it totally needs 3 macros like below as far
as I tried.
```
#define DebugHttp2Con(ua_session, fmt, ...) \
DebugSsn(ua_session, "http2_con", "[%" PRId64 "] " fmt,
ua_session->connection_id(), __VA_ARGS__);
#define DebugHttp2StreamMsg(ua_session, stream_id, msg) \
DebugSsn(ua_session, "http2_stream", "[%" PRId64 "] [%u]" msg,
ua_session->connection_id(), stream_id);
#define DebugHttp2StreamFmt(ua_session, stream_id, fmt, ...) \
DebugSsn(ua_session, "http2_stream", "[%" PRId64 "] [%u]" fmt,
ua_session->connection_id(), stream_id, __VA_ARGS__);
```
Actually this is what we're doing in Http2ClientSession. See
[Http2ClientSession.cc#L34-L36](https://github.com/apache/trafficserver/blob/master/proxy/http2/Http2ClientSession.cc#L34-L36).
Is there better macros technics? Or is this just fine?
> Cleanup debug logs of Http2ConnectionState
> ------------------------------------------
>
> Key: TS-4172
> URL: https://issues.apache.org/jira/browse/TS-4172
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Masaori Koshiba
> Assignee: Masaori Koshiba
> Fix For: 6.2.0
>
>
> 1. {{http2_cs}} debug tag is used in {{Http2ClientSession}} and
> {{Http2ConnectionState}} classes. This sometimes makes me confused when I
> debug HTTP/2 components.
> It is better to change debug tag of {{Http2ConnectionState}} to
> {{http2_conn}}.
> 2. Some debug logs has stream id. It is better that other debug logs in
> {{Http2ConnectionState}} has stream id too.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
