[
https://issues.apache.org/jira/browse/TS-4323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15226370#comment-15226370
]
Leif Hedstrom edited comment on TS-4323 at 4/5/16 3:04 PM:
-----------------------------------------------------------
Looking at the code, seems it's hardcoded at 8KB:
{code}
BUFFER_SIZE_INDEX_8K, // HTTP2_FRAME_TYPE_DATA
{code}
Bumping this to 16K seems to work, which would at least let us be compatible
with the default setting, and the recommendations from H2 specs. Any concerns /
objections to bumping it to 16K ?
Reading the RFC some more, I think if at all possible and safe, I think we
should bump the DATA frame size to 16KB. And then we leave
proxy.config.http2.max_frame_size as is. If we later (we should file a
different Jira) we can make a new configuration option for controlling the DATA
frame size.
Wdyt? If agreeable, then this turns the Jira into changing the default iobuffer
for the DATA frames to 16K.
was (Author: zwoop):
Looking at the code, seems it's hardcoded at 8KB:
{code}
BUFFER_SIZE_INDEX_8K, // HTTP2_FRAME_TYPE_DATA
{code}
Bumping this to 16K seems to work, which would at least let us be compatible
with the default setting, and the recommendations from H2 specs. Any concerns /
objections to bumping it to 16K ?
The RFC seems a little unclear here, indicating that the MAX_FRAME_SIZE can not
be smaller than 16KB either. And implementations MUST support at least 16KB
frames. So, maybe we just hardcode our DATA frame at 16KB, and remove this
configuration, and always make our MAX_FRAME_SIZE to 16K?
> H2 is not using proxy.config.http2.max_frame_size ?
> ---------------------------------------------------
>
> Key: TS-4323
> URL: https://issues.apache.org/jira/browse/TS-4323
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Leif Hedstrom
> Labels: A
> Fix For: 6.2.0
>
>
> While testing / debugging TS-4321, I noticed that it is using DATA frames of
> size 8K only, even though the default configuration says:
> proxy.config.http2.max_frame_size: 16k
> Is that really as intended? Do we not use / honor / support
> proxy.config.http2.max_frame_size ? If so, we should at least change the
> default of proxy.config.http2.max_frame_size, or, if it's not honored, remove
> it?
> But ideally, we ought to use the frame size as set by
> proxy.config.http2.max_frame_size, no?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
