[
https://issues.apache.org/jira/browse/TS-4328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231669#comment-15231669
]
ASF GitHub Bot commented on TS-4328:
------------------------------------
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/554#issuecomment-207223148
I looked at this for a while and I'm not convinced that it doesn't have
unindented side-effects. ``is_request_retryable`` is only set once POST data is
getting sent. Checking the milestone makes more request types non-retryable.
The use of milestones is fairly unfortunate as well; I'd really like to
avoid that.
> Connect_retries re-connects even if request made it to origin (TS-3440 repeat)
> ------------------------------------------------------------------------------
>
> Key: TS-4328
> URL: https://issues.apache.org/jira/browse/TS-4328
> Project: Traffic Server
> Issue Type: Bug
> Reporter: Thomas Jackson
> Assignee: Thomas Jackson
>
> I'm creating another issue as the root bug for TS-3440 can still be
> reproduced if the origin is extremely slow (but no returns no error response).
> I've opened a PR (https://github.com/apache/trafficserver/pull/554) which
> reverts the original patch and instead checks if any bytes where sent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
