[
https://issues.apache.org/jira/browse/TS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243046#comment-15243046
]
ASF GitHub Bot commented on TS-4072:
------------------------------------
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-210488274
While I think unit tests are in general a good idea, I'm not sure how that
could be done in this case and not in the time frame for committing this to
6.2. I expect tests will need to wait for a better test framework (via TSQA or
successor) because of the interaction with the file system. This is especially
acute due to the lack of any pre-existing unit tests which could be extended.
> Diagnostic log rolling races
> ----------------------------
>
> Key: TS-4072
> URL: https://issues.apache.org/jira/browse/TS-4072
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: James Peach
> Assignee: Daniel Xu
> Fix For: 6.2.0
>
>
> When diagnostic logs are rolled, {{Diags::diags_log}} is deleted and replaced
> with a new log object. Since the global {{diags}} points to a a single
> {{Diags}} object there is nothing to prevent a different thread logging
> through this object at the time it is deleted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
