[ 
https://issues.apache.org/jira/browse/TS-4072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15243131#comment-15243131
 ] 

ASF GitHub Bot commented on TS-4072:
------------------------------------

Github user danobi commented on the pull request:

    https://github.com/apache/trafficserver/pull/568#issuecomment-210516157
  
    @jpeach Thanks for the comments.
    
    I've addressed the relevant issues you brought up in the force pushed 
commits. I've also gone ahead and made a separate ticket with the rest of the 
issues [Jira ticket](https://issues.apache.org/jira/browse/TS-4354).


> Diagnostic log rolling races
> ----------------------------
>
>                 Key: TS-4072
>                 URL: https://issues.apache.org/jira/browse/TS-4072
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>            Reporter: James Peach
>            Assignee: Daniel Xu
>             Fix For: 6.2.0
>
>
> When diagnostic logs are rolled, {{Diags::diags_log}} is deleted and replaced 
> with a new log object. Since the global {{diags}} points to a a single 
> {{Diags}} object there is nothing to prevent a different thread logging 
> through this object at the time it is deleted.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to