[ 
https://issues.apache.org/jira/browse/TS-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310832#comment-15310832
 ] 

ASF GitHub Bot commented on TS-4496:
------------------------------------

Github user masaori335 commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/686#discussion_r65416448
  
    --- Diff: mgmt/WebMgmtUtils.h ---
    @@ -113,7 +113,7 @@ bool recordRangeCheck(const char *pattern, const char 
*value);
     bool recordIPCheck(const char *pattern, const char *value);
     bool recordRestartCheck(const char *varName);
     
    -void fileCheckSum(char *buffer, int size, char *checksum, const size_t 
checksumSize);
    +void fileCheckSum(char *buffer, int size, char *checksum);
    --- End diff --
    
    I could not find any call of `fileCheckSum`. Should we remove this too?


> Remove ink_code_md5_stringify
> -----------------------------
>
>                 Key: TS-4496
>                 URL: https://issues.apache.org/jira/browse/TS-4496
>             Project: Traffic Server
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Masaori Koshiba
>             Fix For: 7.0.0
>
>
> {{ink_code_md5_stringify}} is broken and it looks like all of callers can be 
> replaced by {{ink_code_to_hex_str}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to