[
https://issues.apache.org/jira/browse/TS-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313596#comment-15313596
]
ASF GitHub Bot commented on TS-4496:
------------------------------------
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/686#discussion_r65657843
--- Diff: mgmt/api/INKMgmtAPI.cc ---
@@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id)
tsapi TSMgmtError
TSEncryptPassword(char *passwd, char **e_passwd)
--- End diff --
No we don't need to do API review for the management API, only for plugin
APIs.
> On Jun 2, 2016, at 9:37 AM, Masaori Koshiba <[email protected]>
wrote:
>
> In mgmt/api/INKMgmtAPI.cc:
>
> > @@ -1865,8 +1865,7 @@ TSGetErrorMessage(TSMgmtError err_id)
> > tsapi TSMgmtError
> > TSEncryptPassword(char *passwd, char **e_passwd)
> I agree with that. Do we need API review to remove? This looks like one
of TS API.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub, or mute the thread.
>
> Remove ink_code_md5_stringify
> -----------------------------
>
> Key: TS-4496
> URL: https://issues.apache.org/jira/browse/TS-4496
> Project: Traffic Server
> Issue Type: Improvement
> Components: Core
> Reporter: Masaori Koshiba
> Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> {{ink_code_md5_stringify}} is broken and it looks like all of callers can be
> replaced by {{ink_code_to_hex_str}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
