[ 
https://issues.apache.org/jira/browse/TS-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329619#comment-15329619
 ] 

ASF GitHub Bot commented on TS-4531:
------------------------------------

Github user SolidWallOfCode commented on the issue:

    https://github.com/apache/trafficserver/pull/704
  
    I looked at the code and I am not of the opinion the code assumes 
`HOST_DB_TIMEOUT_INTERVAL` is one second. For instance, in 
`HostDBContinuation::backgroundEvent` it is explicitly scaled by 
`HRTIME_SECOND` which is the opposite of assuming it is the specific value one 
second.


> time unit confusion in HostDB sync interval
> -------------------------------------------
>
>                 Key: TS-4531
>                 URL: https://issues.apache.org/jira/browse/TS-4531
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: HostDB
>            Reporter: James Peach
>            Assignee: James Peach
>             Fix For: 7.0.0
>
>
> In {{d48b76e}}, which is part of TS-4331, 
> {{RefCountedHostsFileMap::next_sync_time}} is treated as {{ink_hrtime}} 
> (nanoseconds) but in fact it is {{ink_time_t}} (seconds).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to