[
https://issues.apache.org/jira/browse/TS-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15329627#comment-15329627
]
ASF GitHub Bot commented on TS-4531:
------------------------------------
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/704#discussion_r66988505
--- Diff: iocore/hostdb/HostDB.cc ---
@@ -2224,13 +2227,14 @@ put_hostinfo_ClusterFunction(ClusterHandler *ch,
void *data, int /* len ATS_UNUS
int
HostDBContinuation::backgroundEvent(int /* event ATS_UNUSED */, Event * /*
e ATS_UNUSED */)
{
- ++hostdb_current_interval;
+ // No nothing if hosts file checking is not enabled.
+ if (hostdb_hostfile_check_interval == 0) {
+ return EVENT_CONT;
--- End diff --
Shouldn't this be `EVENT_DONE`? Because it's done, there is no continuing
operation.
> time unit confusion in HostDB sync interval
> -------------------------------------------
>
> Key: TS-4531
> URL: https://issues.apache.org/jira/browse/TS-4531
> Project: Traffic Server
> Issue Type: Bug
> Components: HostDB
> Reporter: James Peach
> Assignee: James Peach
> Fix For: 7.0.0
>
>
> In {{d48b76e}}, which is part of TS-4331,
> {{RefCountedHostsFileMap::next_sync_time}} is treated as {{ink_hrtime}}
> (nanoseconds) but in fact it is {{ink_time_t}} (seconds).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
