[ 
https://issues.apache.org/jira/browse/TS-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15333401#comment-15333401
 ] 

ASF GitHub Bot commented on TS-4551:
------------------------------------

GitHub user shukitchan opened a pull request:

    https://github.com/apache/trafficserver/pull/719

    TS-4551: remove OS_TYPE restriction in gunzip and add unit test

    @zwoop can you please take a quick look and review? Thanks.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shukitchan/trafficserver ostype

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/719.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #719
    
----
commit 7e02353aeaf2d1dc077a07a6f90fbf427054d44a
Author: Kit Chan <[email protected]>
Date:   2016-06-16T08:58:45Z

    remove OS_TYPE restriction in gunzip and add unit test

----


> ESI plugin is unnecessarily checking OS_TYPE to x03 in gunzip of ESI includes
> -----------------------------------------------------------------------------
>
>                 Key: TS-4551
>                 URL: https://issues.apache.org/jira/browse/TS-4551
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Plugins
>            Reporter: Kit Chan
>            Assignee: Kit Chan
>             Fix For: 7.0.0
>
>
> ESI plugin is unnecessarily checking OS_TYPE to x03 in gunzip of ESI includes
> The check is here - 
> https://github.com/apache/trafficserver/blob/master/plugins/experimental/esi/lib/gzip.cc#L133
> It is unnecessary IMO. e.g. I saw some sites such as google homepage and the 
> OS_TYPE can be xff for the 10th bytes of the gzip header bytes of the 
> response. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to