[
https://issues.apache.org/jira/browse/TS-4551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15334017#comment-15334017
]
ASF GitHub Bot commented on TS-4551:
------------------------------------
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/719
I think it looks reasonable. Can you verify that the test programs are only
built at "make check" time? We've had an issue with that with H2 tests, and
want to make sure it doesn't happen here. :).
> ESI plugin is unnecessarily checking OS_TYPE to x03 in gunzip of ESI includes
> -----------------------------------------------------------------------------
>
> Key: TS-4551
> URL: https://issues.apache.org/jira/browse/TS-4551
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Kit Chan
> Assignee: Kit Chan
> Fix For: 7.0.0
>
>
> ESI plugin is unnecessarily checking OS_TYPE to x03 in gunzip of ESI includes
> The check is here -
> https://github.com/apache/trafficserver/blob/master/plugins/experimental/esi/lib/gzip.cc#L133
> It is unnecessary IMO. e.g. I saw some sites such as google homepage and the
> OS_TYPE can be xff for the 10th bytes of the gzip header bytes of the
> response.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
