[
https://issues.apache.org/jira/browse/TS-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345614#comment-15345614
]
ASF GitHub Bot commented on TS-4324:
------------------------------------
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/733
TS-4324: Allocate 16KB for DATA frame payload exactly
- [TS-4324
comment-15313205](https://issues.apache.org/jira/browse/TS-4324?focusedCommentId=15313205&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15313205)
- Separate buffer for frame header from `ioblock` to use all of allocated
`ioblock` for frame payload.
- Call `http2_write_frame_header()` only once. (currently it is called
twice)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserver ts-4324
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/733.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #733
----
commit 5210d7a3dfd0e9e4e656d10da7a0d35dbcb654ef
Author: Masaori Koshiba <[email protected]>
Date: 2016-06-21T11:01:58Z
TS-4324: Allocate 16KB for DATA frame payload exactly
- Cleanup Http2Frame
- Separate frame header and frame payload
----
> Inefficient way of transferring data frames
> -------------------------------------------
>
> Key: TS-4324
> URL: https://issues.apache.org/jira/browse/TS-4324
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Bryan Call
> Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> ATS transfers data 8K - 9 bytes (http/2 header size) and then sends the 9
> bytes is couldn't write in a new frame that only has 9 bytes. This also
> happens if you bump up the buffer size to 16K.
> {code}
> [ 1.036] recv DATA frame <length=8183, flags=0x00, stream_id=13>
> [ 1.036] recv DATA frame <length=9, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=8183, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=9, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=8183, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=9, flags=0x00, stream_id=13>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
