[
https://issues.apache.org/jira/browse/TS-4324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15345675#comment-15345675
]
ASF GitHub Bot commented on TS-4324:
------------------------------------
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/733#discussion_r68171753
--- Diff: proxy/http2/Http2ClientSession.h ---
@@ -65,16 +65,11 @@ class Http2Frame
public:
Http2Frame(const Http2FrameHeader &h, IOBufferReader *r)
{
- this->hdr.cooked = h;
- this->ioreader = r;
- }
-
- Http2Frame(Http2FrameType type, Http2StreamId streamid, uint8_t flags)
- {
- Http2FrameHeader hdr = {0, (uint8_t)type, flags, streamid};
- http2_write_frame_header(hdr, make_iovec(this->hdr.raw));
+ this->hdr = h;
+ this->ioreader = r;
}
+ Http2Frame(Http2FrameType type, Http2StreamId streamid, uint8_t flags) {
this->hdr = {0, (uint8_t)type, flags, streamid}; }
--- End diff --
Should initialize ``ioreader`` to NULL here.
> Inefficient way of transferring data frames
> -------------------------------------------
>
> Key: TS-4324
> URL: https://issues.apache.org/jira/browse/TS-4324
> Project: Traffic Server
> Issue Type: Improvement
> Components: HTTP/2
> Reporter: Bryan Call
> Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
>
> ATS transfers data 8K - 9 bytes (http/2 header size) and then sends the 9
> bytes is couldn't write in a new frame that only has 9 bytes. This also
> happens if you bump up the buffer size to 16K.
> {code}
> [ 1.036] recv DATA frame <length=8183, flags=0x00, stream_id=13>
> [ 1.036] recv DATA frame <length=9, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=8183, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=9, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=8183, flags=0x00, stream_id=13>
> [ 1.259] recv DATA frame <length=9, flags=0x00, stream_id=13>
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
