[
https://issues.apache.org/jira/browse/TS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352495#comment-15352495
]
ASF GitHub Bot commented on TS-4590:
------------------------------------
GitHub user oknet opened a pull request:
https://github.com/apache/trafficserver/pull/752
TS-4590: INKContInternal & INKVConnInternal Optimize
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oknet/trafficserver TS-4590
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/752.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #752
----
commit aae69344e83ecc413830a9f117e2a03ea17b6bc6
Author: Oknet Xu <[email protected]>
Date: 2016-06-28T06:56:07Z
INKContInternal & INKVConnInternal Optimize
----
> INKVConnInternal didn't set m_free_magic to DEAD as INKContInternal
> -------------------------------------------------------------------
>
> Key: TS-4590
> URL: https://issues.apache.org/jira/browse/TS-4590
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Oknet Xu
>
> The class INKContInternal is a base class of INKVConnInternal.
> INKVConnInternal rewrite destroy() and handle_event(), but forgot to set
> m_free_magic to DEAD that is a debug flag.
> I will add 2 methods for INKContInternal and INKVConnInternal:
> - clear()
> - clear variables
> - free()
> - call clear() first
> - call this->mutex.clear();
> - set m_free_magic
> - call xxxAllocator.free(this)
> and rewrite destroy to call free().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
