[
https://issues.apache.org/jira/browse/TS-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353235#comment-15353235
]
ASF GitHub Bot commented on TS-4590:
------------------------------------
Github user oknet commented on the issue:
https://github.com/apache/trafficserver/pull/752
@shinrich INKVConnInternal::handle_event is almost same as
INKContInternal::handle_event but the INKContInternal::handle_event could
handle period event callback status.
They are share handle_event_count() and handle_event_count() also accept
INTERVAL event.
The INKVConnInternal::handle_event() should handle period event callback if
handle_event_count() does. Then the INKVConnInternal::handle_event() is totally
same as INKContInternal::handle_event().
> INKVConnInternal didn't set m_free_magic to DEAD as INKContInternal
> -------------------------------------------------------------------
>
> Key: TS-4590
> URL: https://issues.apache.org/jira/browse/TS-4590
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: Oknet Xu
>
> The class INKContInternal is a base class of INKVConnInternal.
> INKVConnInternal rewrite destroy() and handle_event(), but forgot to set
> m_free_magic to DEAD that is a debug flag.
> I will add 2 methods for INKContInternal and INKVConnInternal:
> - clear()
> - clear variables
> - free()
> - call clear() first
> - call this->mutex.clear();
> - set m_free_magic
> - call xxxAllocator.free(this)
> and rewrite destroy to call free().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
