[
https://issues.apache.org/jira/browse/TS-4432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15352570#comment-15352570
]
ASF GitHub Bot commented on TS-4432:
------------------------------------
Github user oknet commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/642#discussion_r68715180
--- Diff: proxy/InkAPI.cc ---
@@ -6249,12 +6249,12 @@ TSVConnFdCreate(int fd)
vc->action_ = &a;
vc->id = net_next_connection_number();
+ vc->set_context(Net_VConnection_P2S);
vc->submit_time = Thread::get_hrtime();
vc->set_is_transparent(false);
vc->mutex = new_ProxyMutex();
if (vc->connectUp(this_ethread(), fd) != CONNECT_SUCCESS) {
- vc->free(this_ethread());
--- End diff --
sorry, please refer to TS-4432, I file this to a dedicated jira issue.
> TSVConnFdCreate, double free on connectUp failure
> -------------------------------------------------
>
> Key: TS-4432
> URL: https://issues.apache.org/jira/browse/TS-4432
> Project: Traffic Server
> Issue Type: Bug
> Components: TS API
> Reporter: Oknet Xu
> Assignee: James Peach
> Fix For: 7.0.0
>
>
> {{vc->free()}} has been called when connectUp return {CONNECT_FAILURE}.
> but {{TSVConnFdCreate}} call {{vc->free()}} again on {{NOT}}
> {{CONNECT_SUCCESS}}.
> {code}
> if (vc->connectUp(this_ehtread(), fd) != CONNECT_SUCCESS) {
> vc->free(this_ethread());
> return NULL;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
