[
https://issues.apache.org/jira/browse/TS-4332?focusedWorklogId=25675&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25675
]
ASF GitHub Bot logged work on TS-4332:
--------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/16 08:05
Start Date: 19/Jul/16 08:05
Worklog Time Spent: 10m
Work Description: Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/761
I don't think it is a good idea to add another configuration value for
limiting connections. We already have proxy.config.net.max_connections_in for
limiting the number of connections in the LRU. It was managing the LRU size
when the new client sessions were created. It looks like that is still working
with SPDY, but might have been broken in HTTP/2 and HTTP/1.1.
I don't mind that we close the connection earlier in connection
establishment. There is an issue that the connection still can be closed by
the LRU later in the request even if no-throttle is configured on the
connecting port.
Issue Time Tracking
-------------------
Worklog Id: (was: 25675)
Time Spent: 10m
Remaining Estimate: 0h
> proxy.config.net.connections_throttle should allow for immediate error return
> when accepts reach throttle limit
> ---------------------------------------------------------------------------------------------------------------
>
> Key: TS-4332
> URL: https://issues.apache.org/jira/browse/TS-4332
> Project: Traffic Server
> Issue Type: Bug
> Components: Network
> Reporter: Susan Hinrichs
> Assignee: Susan Hinrichs
> Fix For: sometime
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When the throttling kicks in future connections to origins will cause a 502
> to be returned to the user agent.
> But when an accept happens during the throttling period, a message is only
> sent if the unix_netProcessor.throttle_error_message member variable is set.
> In the current code, this member variable is never set. If the variable is
> not set, the logic blocks for 100ms and tries again.
> This spinning causes the ATS process to waste resources. It would be better
> to immediately turn around and send an error response (probably 503 instead
> of 502).
> I tested a build that hard coded an error message and it seemed to recover
> much better.
> I propose adding some config variables to control the throttling behavior.
> proxy.config.connections_throttle.error_code - HTTP response code to return
> (or just hard code this to 503)
> proxy.config.connections_throttle.error_page - Reference to an error page to
> return.
> If both are unset, the existing delaying logic is used. If either is set,
> either a error header or a header and body are returned immediately.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
