[
https://issues.apache.org/jira/browse/TS-4729?focusedWorklogId=26287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26287
]
ASF GitHub Bot logged work on TS-4729:
--------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/16 16:25
Start Date: 10/Aug/16 16:25
Worklog Time Spent: 10m
Work Description: Github user bryancall commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/847#discussion_r74278773
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader
*buf_reader, int64_t write_len,
parent->connection_state.send_headers_frame(this);
// See if the response is chunked. Set up the dechunking logic if
it is
- is_done = this->response_initialize_data_handling();
+ this->response_initialize_data_handling();
--- End diff --
The boolean is not related to if `response_initialize_data_handling` was
successful or not, which is bad coding in my opinion. It is information about
if the response was chunked and if it is finished.
The return value for `response_initialize_data_handling` should be changed.
Issue Time Tracking
-------------------
Worklog Id: (was: 26287)
Time Spent: 1h 10m (was: 1h)
> clang-analyzer: Dead assignment in Http2Stream
> ----------------------------------------------
>
> Key: TS-4729
> URL: https://issues.apache.org/jira/browse/TS-4729
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Masaori Koshiba
> Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {noformat}
> Bug Summary
> File: Http2Stream.cc
> Location: line 508, column 9
> Description: Value stored to 'is_done' is never read
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
