[
https://issues.apache.org/jira/browse/TS-4729?focusedWorklogId=26292&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26292
]
ASF GitHub Bot logged work on TS-4729:
--------------------------------------
Author: ASF GitHub Bot
Created on: 10/Aug/16 19:52
Start Date: 10/Aug/16 19:52
Worklog Time Spent: 10m
Work Description: Github user shinrich commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/847#discussion_r74317308
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader
*buf_reader, int64_t write_len,
parent->connection_state.send_headers_frame(this);
// See if the response is chunked. Set up the dechunking logic if
it is
- is_done = this->response_initialize_data_handling();
+ this->response_initialize_data_handling();
--- End diff --
Actually, the is_done's between response_intiailize_data_handling and
response_process_data are related. If the response is not chunked both will
always return false. If they are chunked, they both return true if the entire
chunk was represent and could be read.
It looks like my patch to open source missed the check on the return from
this->response_initialize_data_handling. There should be
if (is_done) {
send_event = VC_EVENT_WRITE_COMPLETE;
}
I'll add that and set up a new PR.
Issue Time Tracking
-------------------
Worklog Id: (was: 26292)
Time Spent: 1h 20m (was: 1h 10m)
> clang-analyzer: Dead assignment in Http2Stream
> ----------------------------------------------
>
> Key: TS-4729
> URL: https://issues.apache.org/jira/browse/TS-4729
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: Masaori Koshiba
> Assignee: Masaori Koshiba
> Fix For: 7.0.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> {noformat}
> Bug Summary
> File: Http2Stream.cc
> Location: line 508, column 9
> Description: Value stored to 'is_done' is never read
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
