[ 
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26399
 ]

ASF GitHub Bot logged work on TS-2237:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Aug/16 22:06
            Start Date: 12/Aug/16 22:06
    Worklog Time Spent: 10m 
      Work Description: GitHub user shinrich opened a pull request:

    https://github.com/apache/trafficserver/pull/866

    TS-2237: Fix double encoding of URLs in squid logs.

    Resurrecting @sudheerv's fix.  We've been running with this fix for over a 
year.  The logic to lookup the character in the bitfield array is a bit odd, 
but it is the same indexing done for the original character lookup.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/shinrich/trafficserver ts-2237

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/trafficserver/pull/866.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #866
    
----
commit 22c286947308de594564ac2cde8d72463417ea24
Author: shinrich <[email protected]>
Date:   2016-08-12T22:04:04Z

    TS-2237: Fix double encoding of URLs in squid logs.

----


Issue Time Tracking
-------------------

            Worklog Id:     (was: 26399)
            Time Spent: 10m
    Remaining Estimate: 0h

> URL encoding wrong in squid.blog
> --------------------------------
>
>                 Key: TS-2237
>                 URL: https://issues.apache.org/jira/browse/TS-2237
>             Project: Traffic Server
>          Issue Type: Bug
>          Components: Logging
>            Reporter: David Carlin
>            Priority: Minor
>              Labels: yahoo
>             Fix For: sometime
>
>         Attachments: TS-2237.diff
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting 
> 404's for some of them when squid.blog showed a 200 for that request.  Turns 
> out there is an issue with URL encoding.  For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the 
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in 
> %2520
> I tested both the %<cquc> and %<cquuc> log fields - same thing happens.  I 
> tested on ATS 3.2.0 and 3.3.5



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to