[
https://issues.apache.org/jira/browse/TS-2237?focusedWorklogId=26415&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26415
]
ASF GitHub Bot logged work on TS-2237:
--------------------------------------
Author: ASF GitHub Bot
Created on: 14/Aug/16 16:08
Start Date: 14/Aug/16 16:08
Worklog Time Spent: 10m
Work Description: Github user maskit commented on the issue:
https://github.com/apache/trafficserver/pull/866
I don't think this is the right approach. With this change, "%%20" will be
encoded to "%25%20", right? What if "%%20" was not encoded string? It should be
encoded to "%25%2520".
Shouldn't we make sure that all callers of this function pass decoded URLs?
Another options is to abort encoding and return inputs as outputs if input
URLs seem to be already encoded. It can't handle mixed cases but I think it
would't happen. (If it happens, it should be a bug.)
Issue Time Tracking
-------------------
Worklog Id: (was: 26415)
Time Spent: 40m (was: 0.5h)
> URL encoding wrong in squid.blog
> --------------------------------
>
> Key: TS-2237
> URL: https://issues.apache.org/jira/browse/TS-2237
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: David Carlin
> Priority: Minor
> Labels: yahoo
> Fix For: sometime
>
> Attachments: TS-2237.diff
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I was replaying URLs captured from squid.blog and I noticed I was getting
> 404's for some of them when squid.blog showed a 200 for that request. Turns
> out there is an issue with URL encoding. For example:
> Requesting file 'duck%20sports%20authority.gif' via curl will put this in the
> logs:
> duck%2520sports%2520authority.gif
> The % from %20 (space) in the request is being converted to %25 resulting in
> %2520
> I tested both the %<cquc> and %<cquuc> log fields - same thing happens. I
> tested on ATS 3.2.0 and 3.3.5
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
