[ https://issues.apache.org/jira/browse/TS-4763?focusedWorklogId=26627&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26627 ]
ASF GitHub Bot logged work on TS-4763: -------------------------------------- Author: ASF GitHub Bot Created on: 19/Aug/16 02:25 Start Date: 19/Aug/16 02:25 Worklog Time Spent: 10m Work Description: Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/880#discussion_r75419879 --- Diff: proxy/logging/LogAccessHttp.cc --- @@ -769,8 +782,11 @@ LogAccessHttp::marshal_client_req_uuid(char *buf) const char *uuid = (char *)Machine::instance()->uuid.getString(); int len; - len = snprintf(str, _MAX_CRUUID_LEN, "%s-%" PRId64 "", uuid, m_http_sm->sm_id); - marshal_str(buf, str, round_strlen(len + 1)); + len = snprintf(str, sizeof(str), "%s-%" PRId64 "", uuid, m_http_sm->sm_id); --- End diff -- Isn't this fixed/addressed in a separate PR? Issue Time Tracking ------------------- Worklog Id: (was: 26627) Time Spent: 50m (was: 40m) > Consistent request bytes logging tags. > -------------------------------------- > > Key: TS-4763 > URL: https://issues.apache.org/jira/browse/TS-4763 > Project: Traffic Server > Issue Type: Bug > Components: Logging > Reporter: James Peach > Assignee: James Peach > Time Spent: 50m > Remaining Estimate: 0h > > Make the byte count logging tags consistent. We have > {{cqbl}} - client request body length > {{cqhl}} - client request header length > {{pscl}} - client response body length > {{pshl}} - client response header length > {{psql}} - client response total length > {{pqbl}} - server request body length > {{pqhl}} - server request header length > {{sscl}} - server response body length > {{sshl}} - server response header length > We should add {{*ql}} to get the missing totals and standardize on {{*cl}} > for the content length ({{csscl}} marginally tips the balance towards > "content length" in favor of "body length"). -- This message was sent by Atlassian JIRA (v6.3.4#6332)