[
https://issues.apache.org/jira/browse/TS-4763?focusedWorklogId=26628&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-26628
]
ASF GitHub Bot logged work on TS-4763:
--------------------------------------
Author: ASF GitHub Bot
Created on: 19/Aug/16 02:27
Start Date: 19/Aug/16 02:27
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/880#discussion_r75419974
--- Diff: proxy/logging/LogAccess.cc ---
@@ -326,11 +328,11 @@ LogAccess::marshal_proxy_resp_content_type(char *buf)
/*-------------------------------------------------------------------------
-------------------------------------------------------------------------*/
-int
-LogAccess::marshal_proxy_resp_squid_len(char *buf)
-{
- DEFAULT_INT_FIELD;
-}
+LOG_ACCESS_DEFAULT_FIELD(marshal_proxy_resp_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_client_req_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_proxy_req_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_server_resp_squid_len, DEFAULT_INT_FIELD)
+LOG_ACCESS_DEFAULT_FIELD(marshal_cache_resp_squid_len, DEFAULT_INT_FIELD)
--- End diff --
I guess I'm ok with this, just seems a little odd and wildly different from
all other similar code, no?
Issue Time Tracking
-------------------
Worklog Id: (was: 26628)
Time Spent: 1h (was: 50m)
> Consistent request bytes logging tags.
> --------------------------------------
>
> Key: TS-4763
> URL: https://issues.apache.org/jira/browse/TS-4763
> Project: Traffic Server
> Issue Type: Bug
> Components: Logging
> Reporter: James Peach
> Assignee: James Peach
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Make the byte count logging tags consistent. We have
> {{cqbl}} - client request body length
> {{cqhl}} - client request header length
> {{pscl}} - client response body length
> {{pshl}} - client response header length
> {{psql}} - client response total length
> {{pqbl}} - server request body length
> {{pqhl}} - server request header length
> {{sscl}} - server response body length
> {{sshl}} - server response header length
> We should add {{*ql}} to get the missing totals and standardize on {{*cl}}
> for the content length ({{csscl}} marginally tips the balance towards
> "content length" in favor of "body length").
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
