[
https://issues.apache.org/jira/browse/TS-1509?focusedWorklogId=27023&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27023
]
ASF GitHub Bot logged work on TS-1509:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/16 03:34
Start Date: 24/Aug/16 03:34
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/910#discussion_r75990191
--- Diff: lib/ts/apidefs.h.in ---
@@ -124,8 +124,7 @@ typedef struct {
typedef enum {
TS_PARSE_ERROR = -1,
TS_PARSE_DONE = 0,
- TS_PARSE_OK = 1,
- TS_PARSE_CONT = 2,
+ TS_PARSE_CONT = 1,
--- End diff --
I think it would be kinder to plugin authors to leave ``TS_PARSE_CONT = 2``
and ``#define TS_PARSE_OK TS_PARSE_DONE``.
Issue Time Tracking
-------------------
Worklog Id: (was: 27023)
Time Spent: 40m (was: 0.5h)
> Remove TS_PARSE_OK constant
> ---------------------------
>
> Key: TS-1509
> URL: https://issues.apache.org/jira/browse/TS-1509
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: James Peach
> Assignee: Bryan Call
> Priority: Minor
> Labels: api-change, incompatible
> Fix For: 7.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There's TS_PARSE_DONE and TS_PARSE_OK. Which one should a developer handle
> and what's the difference between?
> Well TS_PARSE_OK is never returned from TSHttpParseResp() so we should just
> remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
