[
https://issues.apache.org/jira/browse/TS-1509?focusedWorklogId=27058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-27058
]
ASF GitHub Bot logged work on TS-1509:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Aug/16 17:50
Start Date: 24/Aug/16 17:50
Worklog Time Spent: 10m
Work Description: Github user SolidWallOfCode commented on a diff in the
pull request:
https://github.com/apache/trafficserver/pull/910#discussion_r76105541
--- Diff: lib/ts/apidefs.h.in ---
@@ -124,8 +124,7 @@ typedef struct {
typedef enum {
TS_PARSE_ERROR = -1,
TS_PARSE_DONE = 0,
- TS_PARSE_OK = 1,
- TS_PARSE_CONT = 2,
+ TS_PARSE_CONT = 1,
--- End diff --
I disagree. I think we should kill it with fire. Why pollute the namespace
with a useless name?
Issue Time Tracking
-------------------
Worklog Id: (was: 27058)
Time Spent: 1h (was: 50m)
> Remove TS_PARSE_OK constant
> ---------------------------
>
> Key: TS-1509
> URL: https://issues.apache.org/jira/browse/TS-1509
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: James Peach
> Assignee: Bryan Call
> Priority: Minor
> Labels: api-change, incompatible
> Fix For: 7.0.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> There's TS_PARSE_DONE and TS_PARSE_OK. Which one should a developer handle
> and what's the difference between?
> Well TS_PARSE_OK is never returned from TSHttpParseResp() so we should just
> remove it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
