Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/909#discussion_r76104639
  
    --- Diff: iocore/eventsystem/I_SocketManager.h ---
    @@ -102,7 +110,7 @@ struct SocketManager {
       int dup(int s);
     
       // result is the fd or -errno
    -  int accept(int s, struct sockaddr *addr, socklen_t *addrlen);
    +  int accept4(int s, struct sockaddr *addr, socklen_t *addrlen, int flags 
= 0);
    --- End diff --
    
    I'd leave this as `accept`, no need to drag in external naming conventions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to