Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/909#discussion_r76107280
--- Diff: iocore/eventsystem/I_SocketManager.h ---
@@ -102,7 +110,7 @@ struct SocketManager {
int dup(int s);
// result is the fd or -errno
- int accept(int s, struct sockaddr *addr, socklen_t *addrlen);
+ int accept4(int s, struct sockaddr *addr, socklen_t *addrlen, int flags
= 0);
--- End diff --
I was on the fence about this. I went with the new name because we have a
lot of `accept()` functions floating around and I wanted the change to be
clear. Also, since we are bringing in the new API by emulating `accept4()` on
platforms where it didn't exist, I figured the name change made sense. Do any
others have an opinion about this? @jpeach? @zwoop?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
