Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/938#discussion_r76828573
--- Diff: iocore/net/SSLUtils.cc ---
@@ -544,7 +547,64 @@ ssl_context_enable_ecdh(SSL_CTX *ctx)
return ctx;
}
+static ssl_ticket_key_block *
+ssl_create_ticket_keyblock(const char *ticket_key_path)
--- End diff --
Hmmm, maybe I'm missing something, but it seems most of this code is
duplicated from ssl_context_enable_tickets() ? Can we not refactor this such
that we don't get such massive code duplication?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
