Github user persiaAziz commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/938#discussion_r76831604
--- Diff: iocore/net/SSLUtils.cc ---
@@ -544,7 +547,64 @@ ssl_context_enable_ecdh(SSL_CTX *ctx)
return ctx;
}
+static ssl_ticket_key_block *
+ssl_create_ticket_keyblock(const char *ticket_key_path)
--- End diff --
Yes most of the code are duplicated from the ssl_context_enable_tickets,
but in this function I am just creating the key block not enabling session
ticket for any particular context, So I decided to make a separate function.
What we can do is have ssl_context_enable_ticket call
ssl_create_ticket_keyblock. That way the code will look cleaner
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
