Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/753#discussion_r77096388
--- Diff: iocore/net/I_NetVConnection.h ---
@@ -566,6 +573,21 @@ class NetVConnection : public VConnection
is_transparent = state;
}
+ /// Set the context and return context value
+ NetVConnectionContext_t
+ set_context(NetVConnectionContext_t context)
+ {
+ if (NET_VCONNECTION_UNSET == netvc_context)
+ netvc_context = context;
+ return netvc_context;
+ }
+ /// Get the context.
+ NetVConnectionContext_t
+ get_context() const
+ {
--- End diff --
I know we don't have strong conventions, but I'd prefer to aim for
``context()`` and ``set_context()`` as the member functions. The former reads
better than ``get_context()``. As noted above I'd like to try to eliminate
``set_context()``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
