Github user oknet commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/753#discussion_r77109780
  
    --- Diff: iocore/net/I_NetVConnection.h ---
    @@ -566,6 +573,21 @@ class NetVConnection : public VConnection
         is_transparent = state;
       }
     
    +  /// Set the context and return context value
    +  NetVConnectionContext_t
    +  set_context(NetVConnectionContext_t context)
    --- End diff --
    
    The return value tells you whether it sets successful or not.
    Yes, the context is only set once and will not change.
    - Due to the VC is create by Allocator, It can not be set in the 
constructor.
    - Assert here and set return type to void. ( update later )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to