[ https://issues.apache.org/jira/browse/TS-2258?focusedWorklogId=28841&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28841 ]
ASF GitHub Bot logged work on TS-2258: -------------------------------------- Author: ASF GitHub Bot Created on: 12/Sep/16 18:38 Start Date: 12/Sep/16 18:38 Worklog Time Spent: 10m Work Description: Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/887#discussion_r78429490 --- Diff: mgmt/RecordsConfig.cc --- @@ -67,29 +67,29 @@ static const RecordElement RecordsConfig[] = , {RECT_CONFIG, "proxy.config.alarm_email", RECD_STRING, TS_PKGSYSUSER, RECU_DYNAMIC, RR_NULL, RECC_STR, ".*", RECA_NULL} , - {RECT_CONFIG, "proxy.config.syslog_facility", RECD_STRING, "LOG_DAEMON", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL} + {RECT_CONFIG, "proxy.config.syslog_facility", RECD_STRING, "LOG_DAEMON", RECU_RESTART_TS, RR_NULL, RECC_STR, ".*", RECA_NULL} , //# Negative core limit means max out limit - {RECT_CONFIG, "proxy.config.core_limit", RECD_INT, "-1", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL} + {RECT_CONFIG, "proxy.config.core_limit", RECD_INT, "-1", RECU_RESTART_TS, RR_NULL, RECC_NULL, NULL, RECA_NULL} , {RECT_CONFIG, "proxy.config.crash_log_helper", RECD_STRING, MGMT_CRASHLOG_HELPER, RECU_RESTART_TS, RR_NULL, RECC_NULL, NULL, RECA_NULL} , // 0 - Disabled, 1 - enabled for important pages (e.g. cache directory), 2 - enabled for all pages - {RECT_CONFIG, "proxy.config.mlock_enabled", RECD_INT, "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL} + {RECT_CONFIG, "proxy.config.mlock_enabled", RECD_INT, "0", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-2]", RECA_NULL} --- End diff -- ``proxy.config.mlock_enabled`` only does anything if the value is 2. @zwoop why isn't this a boolean option? Issue Time Tracking ------------------- Worklog Id: (was: 28841) Time Spent: 3h 10m (was: 3h) > Verify that all fields are correct in RecordsConfig.cc > ------------------------------------------------------ > > Key: TS-2258 > URL: https://issues.apache.org/jira/browse/TS-2258 > Project: Traffic Server > Issue Type: Bug > Components: Core > Reporter: Leif Hedstrom > Assignee: Jari Alhonen > Labels: newbie > Fix For: 7.0.0 > > Time Spent: 3h 10m > Remaining Estimate: 0h > > We should go through every configuration in RecordsConfig.cc, and assure that > fields such as if it's dynamically reloadable or not, validation regexes etc. > are all set 100% correct. > Once this file is accurate, and will be the one true authoritative source for > everything "configuration"; it can be used for command line help (e.g. > traffic_line can say if a config is reloadable), and we can even use it as a > source for the Sphinx documentation. > A bonus would be to add a one-line helper line for each configuration in > RecordsConfig.cc. This can again be used for e.g. traffic_line, or for a new > type of tools to help managing configurations. -- This message was sent by Atlassian JIRA (v6.3.4#6332)