[
https://issues.apache.org/jira/browse/TS-2258?focusedWorklogId=28848&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-28848
]
ASF GitHub Bot logged work on TS-2258:
--------------------------------------
Author: ASF GitHub Bot
Created on: 12/Sep/16 18:52
Start Date: 12/Sep/16 18:52
Worklog Time Spent: 10m
Work Description: Github user jpeach commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/887#discussion_r78432072
--- Diff: mgmt/RecordsConfig.cc ---
@@ -103,10 +103,10 @@ static const RecordElement RecordsConfig[] =
,
{RECT_CONFIG, "proxy.config.output.logfile.rolling_size_mb", RECD_INT,
"100", RECU_DYNAMIC, RR_NULL, RECC_STR, "^0*[1-9][0-9]*$", RECA_NULL}
,
- {RECT_CONFIG, "proxy.config.snapshot_dir", RECD_STRING, "snapshots",
RECU_NULL, RR_REQUIRED, RECC_NULL, NULL, RECA_NULL}
+ {RECT_CONFIG, "proxy.config.snapshot_dir", RECD_STRING, "snapshots",
RECU_DYNAMIC, RR_REQUIRED, RECC_NULL, NULL, RECA_NULL}
--- End diff --
I think this should be ``RECU_RESTART_TM`` since the manager reads it in
the constructor and never re-reads it AFAICT.
Issue Time Tracking
-------------------
Worklog Id: (was: 28848)
Time Spent: 4h 20m (was: 4h 10m)
> Verify that all fields are correct in RecordsConfig.cc
> ------------------------------------------------------
>
> Key: TS-2258
> URL: https://issues.apache.org/jira/browse/TS-2258
> Project: Traffic Server
> Issue Type: Bug
> Components: Core
> Reporter: Leif Hedstrom
> Assignee: Jari Alhonen
> Labels: newbie
> Fix For: 7.0.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> We should go through every configuration in RecordsConfig.cc, and assure that
> fields such as if it's dynamically reloadable or not, validation regexes etc.
> are all set 100% correct.
> Once this file is accurate, and will be the one true authoritative source for
> everything "configuration"; it can be used for command line help (e.g.
> traffic_line can say if a config is reloadable), and we can even use it as a
> source for the Sphinx documentation.
> A bonus would be to add a one-line helper line for each configuration in
> RecordsConfig.cc. This can again be used for e.g. traffic_line, or for a new
> type of tools to help managing configurations.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
