Github user SolidWallOfCode commented on a diff in the pull request:
    --- Diff: iocore/net/BIO_fastopen.h ---
    @@ -0,0 +1,38 @@
    +/** @file
    + *
    + *  OpenSSL socket BIO that does TCP Fast Open.
    + *
    + *  @section license License
    + *
    + *  Licensed to the Apache Software Foundation (ASF) under one
    + *  or more contributor license agreements.  See the NOTICE file
    + *  distributed with this work for additional information
    + *  regarding copyright ownership.  The ASF licenses this file
    + *  to you under the Apache License, Version 2.0 (the
    + *  "License"); you may not use this file except in compliance
    + *  with the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + */
    +#ifndef BIO_FASTOPEN_H_DA87E080_DB75_4C9C_959A_40243592D454
    +#define BIO_FASTOPEN_H_DA87E080_DB75_4C9C_959A_40243592D454
    +#include <openssl/bio.h>
    +// Return a BIO_METHOD for a socket BIO that implements TCP Fast Open.
    +const BIO_METHOD *BIO_s_fastopen();
    +// OpenSSL 1.0.2h has BIO_set_conn_ip(), but master has 
BIO_set_conn_address(). Use
    +// the API from master since it makes more sense.
    +#if !defined(BIO_set_conn_address)
    +#define BIO_set_conn_address(b, addr) BIO_ctrl(b, BIO_C_SET_CONNECT, 2, 
(char *)addr)
    --- End diff --
    We're using C++, perhaps an inline function instead of `#define`?

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to