Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1036#discussion_r80173011
  
    --- Diff: iocore/net/UnixNetVConnection.cc ---
    @@ -990,7 +991,28 @@ UnixNetVConnection::load_buffer_and_write(int64_t 
towrite, MIOBufferAccessor &bu
     
         ink_assert(niov > 0);
         ink_assert(niov <= countof(tiovec));
    -    r = socketManager.writev(con.fd, &tiovec[0], niov);
    +
    +#if DEBUG && (TCP_FASTOPEN == 0)
    --- End diff --
    
    `ink_assert` is only in debug mode, so that check is not useful. The other 
check should be blended in, e.g.
    ```
    ink_assert(TCP_FASTOPEN != 0 || ! this->options.f_tcp_fastopen);
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to