Github user SolidWallOfCode commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1036#discussion_r80301651
  
    --- Diff: iocore/eventsystem/SocketManager.cc ---
    @@ -108,3 +111,36 @@ SocketManager::close(int s)
       } while (res == -EINTR);
       return res;
     }
    +
    +bool
    +SocketManager::fastopen_supported()
    --- End diff --
    
    Ah. I would say then that it shouldn't be a method, it should be a file 
scoped function called by reconfigure. I don't think we want to be checking on 
every open.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to