[
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29975&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29975
]
ASF GitHub Bot logged work on TS-4908:
--------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/16 22:08
Start Date: 29/Sep/16 22:08
Worklog Time Spent: 10m
Work Description: Github user shinrich commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1062#discussion_r81245130
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -356,8 +356,6 @@ Http2Stream::transaction_done()
if (closed) {
// Safe to initiate SSN_CLOSE if this is the last stream
- if (cross_thread_event)
- cross_thread_event->cancel();
// Schedule the destroy to occur after we unwind here. IF we call
directly, may delete with reference on the stack.
--- End diff --
This seems like a reasonable cleanup unless the earlier do_io_close could
cause the cross_thread_event to be set again. NULLing out cross_thread_event
earlier and adding an assert here would be reasonable.
However this fix doesn't seem to match the title. Canceling the event is
not going to cause the close to happen twice.
Issue Time Tracking
-------------------
Worklog Id: (was: 29975)
Time Spent: 50m (was: 40m)
> HTTP2Stream tries to close a continuation twice when a transaction is done
> --------------------------------------------------------------------------
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: David Calavera
> Fix For: 7.1.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request
> coming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
