[
https://issues.apache.org/jira/browse/TS-4908?focusedWorklogId=29981&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29981
]
ASF GitHub Bot logged work on TS-4908:
--------------------------------------
Author: ASF GitHub Bot
Created on: 29/Sep/16 22:21
Start Date: 29/Sep/16 22:21
Worklog Time Spent: 10m
Work Description: Github user calavera commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1062#discussion_r81247196
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -356,8 +356,6 @@ Http2Stream::transaction_done()
if (closed) {
// Safe to initiate SSN_CLOSE if this is the last stream
- if (cross_thread_event)
- cross_thread_event->cancel();
// Schedule the destroy to occur after we unwind here. IF we call
directly, may delete with reference on the stack.
--- End diff --
If do_io_close set the event again, would it make sense to check if the
even is cancelled rather than removing this code? In our tests, this doesn't
happen, but I'm not familiar with the code to be sure it never happens.
Issue Time Tracking
-------------------
Worklog Id: (was: 29981)
Time Spent: 1h 10m (was: 1h)
> HTTP2Stream tries to close a continuation twice when a transaction is done
> --------------------------------------------------------------------------
>
> Key: TS-4908
> URL: https://issues.apache.org/jira/browse/TS-4908
> Project: Traffic Server
> Issue Type: Bug
> Components: HTTP/2
> Reporter: David Calavera
> Fix For: 7.1.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This causes an assertion error when ATS is built in debug mode. Pull Request
> coming.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
