Github user shinrich commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1100#discussion_r83290881
  
    --- Diff: proxy/http2/Http2ConnectionState.cc ---
    @@ -936,30 +940,70 @@ Http2ConnectionState::cleanup_streams()
     void
     Http2ConnectionState::delete_stream(Http2Stream *stream)
     {
    +  // The following check allows the method to be called safely on already 
deleted streams.
    +  if (deleted_from_active_streams(stream)) {
    +    return;
    +  }
    +
    +  SCOPED_MUTEX_LOCK(lock, this->mutex, this_ethread());
    +
    --- End diff --
    
    Why do you need to grab a lock here?  Given the mutex sharing between vc 
and session and ConnectionState, we should already be holding this mutex.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to