Github user shinrich commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1100#discussion_r83291283
  
    --- Diff: proxy/http2/Http2Stream.cc ---
    @@ -267,10 +267,12 @@ Http2Stream::do_io_close(int /* flags */)
           // Make sure any trailing end of stream frames are sent
           // Ourselve will be removed at send_data_frames or closing 
connection phase
           static_cast<Http2ClientSession 
*>(parent)->connection_state.send_data_frames(this);
    +
    +      // Make sure the stream is deleted at this point since next step is 
self destroy.
    +      this->delete_stream();
    --- End diff --
    
    It isn't clear to me that this delete_stream is necessary either.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to