Github user jpeach commented on a diff in the pull request:
    --- Diff: plugins/esi/fetcher/ ---
    @@ -80,7 +80,7 @@ HttpDataFetcherImpl::addFetchRequest(const string &url, 
FetchedDataProcessor *ca
       if (length < (int)sizeof(buff)) {
         http_req = buff;
       } else {
    -    http_req = (char *)malloc(length + 1);
    +    http_req = static_cast<char *>(malloc(length + 1));
    --- End diff --
    I'm not convinced by ``static_cast`` on ``malloc()``. It does nothing but 
look uglier. It would be better not to include so many different changes in 
this PR.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

Reply via email to