Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1110#discussion_r83534526
--- Diff: plugins/authproxy/authproxy.cc ---
@@ -682,10 +682,10 @@ AuthParseOptions(int argc, const char **argv)
// on some platforms (e.g. Solaris / Illumos). On sane platforms (e.g.
linux), it'll get
// automatically casted back to the const char*, as the struct is
defined in <getopt.h>.
static const struct option longopt[] = {
- {const_cast<char *>("auth-host"), required_argument, 0, 'h'},
- {const_cast<char *>("auth-port"), required_argument, 0, 'p'},
- {const_cast<char *>("auth-transform"), required_argument, 0, 't'},
- {const_cast<char *>("force-cacheability"), no_argument, 0, 'c'},
+ {"auth-host", required_argument, 0, 'h'},
+ {"auth-port", required_argument, 0, 'p'},
+ {"auth-transform", required_argument, 0, 't'},
+ {"force-cacheability", no_argument, 0, 'c'},
--- End diff --
This change will break Solaris.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
