Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1073#discussion_r84208323
--- Diff: mgmt/LocalManager.cc ---
@@ -239,8 +239,9 @@ LocalManager::LocalManager(bool proxy_on) :
BaseManager(), run_proxy(proxy_on),
process_server_timeout_msecs =
REC_readInteger("proxy.config.lm.pserver_timeout_msecs", &found);
proxy_name = REC_readString("proxy.config.proxy_name",
&found);
proxy_binary =
REC_readString("proxy.config.proxy_binary", &found);
- proxy_options =
REC_readString("proxy.config.proxy_binary_opts", &found);
env_prep = REC_readString("proxy.config.env_prep",
&found);
+ proxy_options = new char[1];
+ strcpy(proxy_options, ""); // so later we can always `delete
proxy_options` without worrying
--- End diff --
You don't need this. It is safe for ``proxy_options`` to be NULL.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
