Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1073#discussion_r86604224
--- Diff: mgmt/LocalManager.cc ---
@@ -902,8 +906,13 @@ LocalManager::startProxy()
Vec<char> real_proxy_options;
real_proxy_options.append(proxy_options, strlen(proxy_options));
+ if (onetime_options && *onetime_options) {
+ real_proxy_options.append(" ", strlen(" "));
+ real_proxy_options.append(onetime_options, strlen(onetime_options));
+ }
- if (!strstr(proxy_options, MGMT_OPT)) { // Make sure we're starting
the proxy in mgmt mode
+ // Make sure we're starting the proxy in mgmt mode
+ if (strstr(proxy_options, MGMT_OPT) == 0 && strstr(onetime_options,
MGMT_OPT) == 0) {
--- End diff --
Couldn't you just check `real_proxy_options` here? If `onetime_options`
aren't already in there, they won't be added anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
