[
https://issues.apache.org/jira/browse/TS-5024?focusedWorklogId=31380&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31380
]
ASF GitHub Bot logged work on TS-5024:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Nov/16 14:45
Start Date: 01/Nov/16 14:45
Worklog Time Spent: 10m
Work Description: Github user oschaaf commented on a diff in the pull
request:
https://github.com/apache/trafficserver/pull/1166#discussion_r85942529
--- Diff: plugins/gzip/gzip.cc ---
@@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server,
HostConfiguration *host_configur
resp_status = TSHttpHdrStatusGet(bufp, hdr_loc);
- // conservatively pick some statusses to compress
- if (!(resp_status == 200 || resp_status == 404 || resp_status == 500)) {
+ // conservatively pick some statusses to compress. ToDo: Make this
configurable?
+ if (resp_status != 200) {
--- End diff --
This seems like a good change to me, it's the probably safer default -- but
is it possible that we see `200/OK` two times here when the HttpSM is
restarted?
Issue Time Tracking
-------------------
Worklog Id: (was: 31380)
Time Spent: 40m (was: 0.5h)
> Gzip plugin gzips multiple times
> --------------------------------
>
> Key: TS-5024
> URL: https://issues.apache.org/jira/browse/TS-5024
> Project: Traffic Server
> Issue Type: Bug
> Components: Plugins
> Reporter: Meera Mosale Nataraja
> Assignee: Leif Hedstrom
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Gzip plugin gzips multiple times when you enable redirection by following
> settings or using escalate plugin.
> Enable redirection:
> CONFIG proxy.config.http.redirection_enabled INT 1
> CONFIG proxy.config.http.number_of_redirections INT 3
> Curl command output is provided below. Notice multiple "Content-Encoding:
> gzip" headers.
> curl -v -o/dev/null http://proxy-test:8080/get -H "Host: proxy-test" -x
> localhost:8080 -H "Accept-encoding: gzip"
> * About to connect() to proxy localhost port 8080 (#0)
> * Trying ::1... connected
> * Connected to localhost (::1) port 8080 (#0)
> > GET http://proxy-test:8080/get HTTP/1.1
> > User-Agent: curl/7.19.7 (x86_64-redhat-linux-gnu) libcurl/7.19.7 NSS/3.21
> > Basic ECC zlib/1.2.3 libidn/1.18 libssh2/1.4.2
> > Accept: */*
> > Proxy-Connection: Keep-Alive
> > Host: proxy-test
> > Accept-encoding: gzip
> >
> % Total % Received % Xferd Average Speed Time Time Time
> Current
> Dload Upload Total Spent Left Speed
> 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:--
> 0< HTTP/1.1 404 Not Found
> < Server: ATS/7.1.0
> < X-Frame-Options: SAMEORIGIN
> < X-Xss-Protection: 1; mode=block
> < Accept-Ranges: bytes
> < X-Content-Type-Options: nosniff
> < Content-Type: text/html; charset=UTF-8
> < Cache-Control: max-age=300
> < Expires: Mon, 31 Oct 2016 18:29:44 GMT
> < Date: Mon, 31 Oct 2016 18:24:44 GMT
> < Content-Encoding: gzip
> < Vary: Accept-Encoding
> < Content-Encoding: gzip
> < Content-Encoding: gzip
> < Content-Length: 4456
> < Age: 0
> < Proxy-Connection: keep-alive
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
