[ https://issues.apache.org/jira/browse/TS-5024?focusedWorklogId=31389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-31389 ]
ASF GitHub Bot logged work on TS-5024: -------------------------------------- Author: ASF GitHub Bot Created on: 01/Nov/16 16:43 Start Date: 01/Nov/16 16:43 Worklog Time Spent: 10m Work Description: Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1166#discussion_r85968661 --- Diff: plugins/gzip/gzip.cc --- @@ -480,8 +480,8 @@ gzip_transformable(TSHttpTxn txnp, bool server, HostConfiguration *host_configur resp_status = TSHttpHdrStatusGet(bufp, hdr_loc); - // conservatively pick some statusses to compress - if (!(resp_status == 200 || resp_status == 404 || resp_status == 500)) { + // conservatively pick some statusses to compress. ToDo: Make this configurable? + if (resp_status != 200) { --- End diff -- @oschaaf It is *possible*, but unlikely. The immediate issues we're having is that gzip works very poorly together with the escalate plugin, but you wouldn't escalate on a 200 OK. Long term, @meeramn is going to add a new plugin API, that enforces uniqueness on the continuations added to a hook. Issue Time Tracking ------------------- Worklog Id: (was: 31389) Time Spent: 50m (was: 40m) > Gzip plugin gzips multiple times > -------------------------------- > > Key: TS-5024 > URL: https://issues.apache.org/jira/browse/TS-5024 > Project: Traffic Server > Issue Type: Bug > Components: Plugins > Reporter: Meera Mosale Nataraja > Assignee: Leif Hedstrom > Time Spent: 50m > Remaining Estimate: 0h > > Gzip plugin gzips multiple times when you enable redirection by following > settings or using escalate plugin. > Enable redirection: > CONFIG proxy.config.http.redirection_enabled INT 1 > CONFIG proxy.config.http.number_of_redirections INT 3 > Curl command output is provided below. Notice multiple "Content-Encoding: > gzip" headers. > curl -v -o/dev/null http://proxy-test:8080/get -H "Host: proxy-test" -x > localhost:8080 -H "Accept-encoding: gzip" > * About to connect() to proxy localhost port 8080 (#0) > * Trying ::1... connected > * Connected to localhost (::1) port 8080 (#0) > > GET http://proxy-test:8080/get HTTP/1.1 > > User-Agent: curl/7.19.7 (x86_64-redhat-linux-gnu) libcurl/7.19.7 NSS/3.21 > > Basic ECC zlib/1.2.3 libidn/1.18 libssh2/1.4.2 > > Accept: */* > > Proxy-Connection: Keep-Alive > > Host: proxy-test > > Accept-encoding: gzip > > > % Total % Received % Xferd Average Speed Time Time Time > Current > Dload Upload Total Spent Left Speed > 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- > 0< HTTP/1.1 404 Not Found > < Server: ATS/7.1.0 > < X-Frame-Options: SAMEORIGIN > < X-Xss-Protection: 1; mode=block > < Accept-Ranges: bytes > < X-Content-Type-Options: nosniff > < Content-Type: text/html; charset=UTF-8 > < Cache-Control: max-age=300 > < Expires: Mon, 31 Oct 2016 18:29:44 GMT > < Date: Mon, 31 Oct 2016 18:24:44 GMT > < Content-Encoding: gzip > < Vary: Accept-Encoding > < Content-Encoding: gzip > < Content-Encoding: gzip > < Content-Length: 4456 > < Age: 0 > < Proxy-Connection: keep-alive -- This message was sent by Atlassian JIRA (v6.3.4#6332)