[
https://issues.apache.org/jira/browse/TS-5030?focusedWorklogId=32003&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-32003
]
ASF GitHub Bot logged work on TS-5030:
--------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/16 01:59
Start Date: 13/Nov/16 01:59
Worklog Time Spent: 10m
Work Description: Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1184
I'm still not convinced this is a particularly useful API, but it's also
fairly benign. However, I do feel that if we are going to do this, we should
make the prototype something like:
```C
TSStatusCode TSClientRequestUuidGet(TSHttpTxn txnp, char* destination)
```
or something with a fixed size array, like
```C
TSStatusCode TSClientRequestUuidGet(TSHttpTxn txnp, char
destination[MAX_SIZE_OF_THIS_BAD_BOY)
```
Where the caller is in charge of allocating enough storage for
"destination". This allows it to in most cases be statically allocated (on the
stack).
Also, the patch as it is is not right, you can't return a pointer into the
arena, after you released it. But that's a moot point if we change the
signature as the above.
Issue Time Tracking
-------------------
Worklog Id: (was: 32003)
Time Spent: 1.5h (was: 1h 20m)
> Proposal: Add API to get the client request UUID directly from a TSHttpTx
> -------------------------------------------------------------------------
>
> Key: TS-5030
> URL: https://issues.apache.org/jira/browse/TS-5030
> Project: Traffic Server
> Issue Type: Improvement
> Components: TS API
> Reporter: David Calavera
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> The new UUID api introduced in
> https://github.com/apache/trafficserver/pull/736 is great for tracing
> operations and requests. However, the most useful information for plugin
> developers, the unique client request id, is not exposed as an api endpoint.
> People need to understand very well how TrafficServer works internally to
> generate this value. By not having the API directly exposed, people need to
> repeat the same code every time they want to generate this unique identifier.
> I'd like to add an API enpoint to generate this identifier based in a given
> http transaction for plugins to use.
> This would be the signature:
> tsapi const char * TSClientRequestUuidGet(TSHttpTxn txnp);
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
